-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Author reward dest pallet benchmark #14
Conversation
I think the problem is with the chain spec and stuff. Not sure that |
@thiolliere should be fixed now. I ran your exact commands above successfully. You could also change to use |
.saturating_add(RocksDbWeight::get().reads(1_u64)) | ||
.saturating_add(RocksDbWeight::get().writes(1_u64)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically, you delete the storage at the end of the block, so you don't even need to count the storage write, but its okay, better to be conservative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I should have put the finalize
hook in the benchmark
Simple benchmark for pallet author reward dest, without the final benchmarked weight.