Adds Snowbridge to Kusama and Polkadot Runtimes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
changed the title
Closed
claravanstaden
force-pushed
the
sv-pk-bridge-snowbridge
branch
4 times, most recently
from
2aff354
to
4fcef54
Compare
claravanstaden
force-pushed
the
sv-pk-bridge-snowbridge
branch
from
c9df1c2
to
237f0ca
Compare
Co-authored-by: Ross Bulat <ross@parity.io>
Co-authored-by: Ross Bulat <ross@parity.io>
Co-authored-by: Ross Bulat <ross@parity.io>
Co-authored-by: Ross Bulat <ross@parity.io>
…otal_issuance)
# Conflicts: # Cargo.lock # relay/kusama/constants/Cargo.toml # relay/polkadot/constants/Cargo.toml # system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs # system-parachains/bridge-hubs/bridge-hub-kusama/tests/tests.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/xcm_config.rs
# Conflicts: # Cargo.lock # relay/kusama/constants/Cargo.toml # relay/polkadot/constants/Cargo.toml # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs
…-pk-bridge-snowbridge
# Conflicts: # CHANGELOG.md # integration-tests/emulated/chains/parachains/testing/penpal/Cargo.toml # system-parachains/asset-hubs/asset-hub-kusama/src/xcm_config.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/xcm_config.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs
…bko-snowbridge-nits
…oreign_asset_pallet_deposit` to the AH runtimes
…-pk-bridge-snowbridge
Nits for Snowbridge + stuff moving around
bkontur
approved these changes
Mar 20, 2024
Comment on lines
807
to
809
| /// User fee for ERC20 token transfer back to Ethereum. | ||
| /// Configure the fee to max Balance so that it is disabled. | ||
| /// Sensible value was 2_750_872_500_000. |
There was a problem hiding this comment.
This is not just about ERC20 token, this fee is applied whatever transfer we will do to the Ethereum with BridgeTable.
And all other tokens are disabled also, unless the governance sets the fee, right?
What does it mean "Sensible value was...."?
I would suggest to update this doc and also for AHP.
Comment on lines
+147
to
+151
| snowbridge_pallet_system::migration::v0::InitializeOnUpgrade< | ||
| Runtime, | ||
| ConstU32<BRIDGE_HUB_ID>, | ||
| ConstU32<ASSET_HUB_ID>, | ||
| >, |
There was a problem hiding this comment.
@claravanstaden Is this a one-time shot, or do we need it for every runtime upgrade? If it's the former, please move it before // permanent
| @@ -326,6 +328,21 @@ pub fn can_calculate_weight_for_paid_export_message_with_reserve_transfer() { | |||
| ) | |||
| } | |||
|
|
|||
| #[test] | |||
| fn change_ethereum_gateway_by_governance_works() { | |||
There was a problem hiding this comment.
@claravanstaden very nit, why not to move it to the tests/snowbridge.rs also for BHP
|
@claravanstaden I think this is ready to merge now, yes? |
|
@acatangiu yes, thank you! |
|
/merge |
fellowship-merge-bot
bot
merged commit 14cd363
into
polkadot-fellows:main
33 of 34 checks passed
|
Enabled Available commands
For more information see the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot-sdk 1.7.0polkadot-sdk@1.5release #137FeeManagerhandle_feemisses reason, crate needs to be updated I thinkcc @vgeddes @alistair-singh @yrong @musnit