Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade api to use MetadataV6 #1354

Merged
merged 4 commits into from
Jul 3, 2019
Merged

Upgrade api to use MetadataV6 #1354

merged 4 commits into from
Jul 3, 2019

Conversation

amaury1093
Copy link
Contributor

Pulls in polkadot-js/api#1059

Works with latest master right after Basti's PR got merged in.

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a peek at the changes, all good. Not sure why CI is throwing a hissy fit.

@pmespresso
Copy link
Contributor

note on the CI hissy fit - StorageFunction was renamed to StorageEntry in Basti's PR and hence also renamed in metadata v6.

@amaury1093
Copy link
Contributor Author

Yeah, I'll fix that.

@yjkimjunior Btw could you add a BREAKING CHANGE entry in the Changelog in api? I think this is worth mentioning for users

@amaury1093 amaury1093 merged commit f4fc064 into master Jul 3, 2019
@amaury1093 amaury1093 deleted the am-upgrade-api branch July 3, 2019 09:21
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants