Support for Moonbeam addresses in Signer + Extension

[montekki]

• I'm submitting a ...

• Bug report
• Feature request
• Support request
• Other

• What is the current behavior and expected behavior?

With the start of development of support for Eth-like addresses in Signer in novasamatech/parity-signer#1268 we've found out that adding these arrds from Signer into the Extension with QR codes does not work. The format that we are using now is ethereum:ETH_KEY:GENESIS_HASH just like substrate:SS58_KEY:GENESIS_HASH for any other network

Full working support of Ethereum addresses and keys between Signer and Polkadot-js

• What is the motivation for changing the behavior?

So people could use Signer on Moon* networks.

• Please tell us about your environment:

• Version: 0.44.1

• Environment: Firefox

  • Node.js
  • Browser
  • Other (limited support for other environments)

• Language:

  • JavaScript
  • TypeScript (include tsc --version)
  • Other

[polkadot-js-bot]

This issue has been open for 21 days with no activity and is not labelled as an enhancement. It will be closed in 7 days.

[jacogr]

Most probably needs to move to the ui repo - QRs are parsed in the react-qr package ( as I recall).

EDIT: Indeed, there is only Substrate support (prefix being the substrate constant),

ui/packages/react-qr/src/util.ts

Lines 31 to 33 in 7d9fb90

	export function createAddressPayload (address: string, genesisHash: string): Uint8Array {
	return encodeString(`${ADDRESS_PREFIX}:${address}:${genesisHash}`);
	}

So would have some bubble-up effects in the display component as well where it would need additional flags (and then finally to the users of these components). Most probably needs some optional (important, needs backwards compat for existing users) flag to indicate anything that is non-Substrate prefixed.