Fix crash in SendPacket(), packet.SendPacket() and DisconnectClient()…

… when the client was not yet logged in.

Those functions expected chrptr to be null when a character wasn't assigned to a client, but they instead got an uninitialized pointer. This caused a memory access error that crashed POL. Initializing those pointers to null fixes the issue.

docs/docs.polserver.com/pol100/corechanges.xml

@@ -5,11 +5,16 @@
 		<datemodified>02-27-2021</datemodified>
 	</header>
 	<version name="POL100">
+		<entry>
+			<date>02-27-2021</date>
+			<author>Nando:</author>
+			<change type="Fix">Crash in SendPacket(), packet.SendPacket() and DisconnectClient() when the client was not yet logged in. Mostly affects packet hooks.</change>
+		</entry>
 		<entry>
 			<date>02-27-2020</date>
 			<author>Turley, Kevin:</author>
 			<change type="Added">os::GetEnvironmentVariable(name:=&quot;&quot;)<br/>
-Returns String value of given environment variable name. If name is empty, returns Dictionary of all allowed environment variables.<br/>
+Returns String value of given environment variable name. If name is empty, returns Dictionary of all environment variables.<br/>
 The pol.cfg setting AllowedEnvironmentVariablesAccess controls script access to this function. See documentation for more details.</change>
 		</entry>
 		<entry>

pol-core/doc/core-changes.txt

@@ -1,4 +1,6 @@
 -- POL100 --
+02-27-2021 Nando:
+      Fix: Crash in SendPacket(), packet.SendPacket() and DisconnectClient() when the client was not yet logged in. Mostly affects packet hooks.
 02-27-2020 Turley, Kevin:
     Added: os::GetEnvironmentVariable(name:="")
            Returns String value of given environment variable name. If name is empty, returns Dictionary of all environment variables.

pol-core/pol/uoexec.cpp

@@ -213,6 +213,9 @@ using namespace Module;
 bool UOExecutor::getCharacterOrClientParam( unsigned param, Mobile::Character*& chrptr,
                                             Network::Client*& clientptr )
 {
+  chrptr = nullptr;
+  clientptr = nullptr;
+
   BObjectImp* imp = getParamImp( param );
   if ( imp == nullptr )
   {