check client has a character in SendOverallSeason

polserver · Apr 28, 2022 · 578b48f · 578b48f
1 parent 5c969ed
commit 578b48f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/docs/docs.polserver.com/pol100/corechanges.xml b/docs/docs.polserver.com/pol100/corechanges.xml
@@ -2,9 +2,14 @@
 <ESCRIPT>
 	<header>
 		<topic>Latest Core Changes</topic>
-		<datemodified>04-12-2022</datemodified>
+		<datemodified>04-29-2022</datemodified>
 	</header>
 	<version name="POL100.1.0">
+		<entry>
+			<date>04-29-2022</date>
+			<author>Kevin:</author>
+			<change type="Fixed">`SendOverallSeason` now checks that connected clients have a character.</change>
+		</entry>
 		<entry>
 			<date>04-12-2022</date>
 			<author>Kevin:</author>

diff --git a/pol-core/doc/core-changes.txt b/pol-core/doc/core-changes.txt
@@ -1,4 +1,6 @@
--- POL100.1.0 --
+-- POL100.1.0 --
+04-29-2022 Kevin:
+    Fixed: `SendOverallSeason` now checks that connected clients have a character.
 04-12-2022 Kevin:
     Added: Boolean property `client.disable_inactivity_timeout`.
            If true, the client will not be disconnected due to inactivity.

diff --git a/pol-core/pol/module/uomod.cpp b/pol-core/pol/module/uomod.cpp
@@ -5417,7 +5417,7 @@ BObjectImp* UOExecutorModule::mf_SendOverallSeason( /*season_id, playsound := 1*
           itr != end; ++itr )
     {
       Network::Client* client = *itr;
-      if ( !client->chr->logged_in() || client->getversiondetail().major < 1 )
+      if ( !client->chr || !client->chr->logged_in() || client->getversiondetail().major < 1 )
         continue;
       msg.Send( client );
     }