Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth Boat pkt: overflow/invis objects #403

Merged
merged 28 commits into from Jun 21, 2021
Merged

Conversation

turleypol
Copy link
Member

@turleypol turleypol commented Jun 20, 2021

Rewrite smooth boat pkt so it does not leak info of invisible objects. Send the correct objcount when truncating.
Testclient is now version 7
New tests:

  • move a boat with a client on it while more items exists then the boat pkt can handle
  • move a boat and check if the client gets the correct pos of boat and containing item

@coveralls
Copy link
Collaborator

coveralls commented Jun 20, 2021

Coverage Status

Coverage increased (+0.5%) to 40.465% when pulling 2cb3b23 on boat_item_overflow into 2cb05d8 on master.

@turleypol turleypol changed the title Boat item overflow test Smooth Boat pkt: overflow/invis objects Jun 20, 2021
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@turleypol turleypol merged commit aa6b0ec into master Jun 21, 2021
@turleypol turleypol deleted the boat_item_overflow branch June 21, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants