New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include items on exterior stairs of custom houses in MultiRef.items #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEady
changed the title
Include items on exterior stairs of custom houses to MultiRef.items
Include items on exterior stairs of custom houses in MultiRef.items
Feb 28, 2023
turleypol
reviewed
Mar 7, 2023
pol-core/pol/multi/customhouses.h
Outdated
@@ -175,6 +176,8 @@ void CustomHousesSendFull( UHouse* house, Network::Client* client, | |||
void CustomHousesSendFullToInRange( UHouse* house, int design, int range ); | |||
void CustomHousesSendShort( UHouse* house, Network::Client* client ); | |||
void CustomHouseStopEditing( Mobile::Character* chr, UHouse* house, bool send_pkts = true ); | |||
void CustomHouseStopEditing( Mobile::Character* chr, UHouse* house, ItemList& foo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foo? :)
A comment why these two versions exists would be good when we cannot get rid of the second version, otherwise we will forget it.
turleypol
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items on exterior stairs of custom houses were not being included in the multi's
item
script member.Here is a script where I target the robe, check
robe.multi
, and loop throughrobe.multi.items
:First iteration shows the robe not included, and second iteration shows robe included: