New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagnostics: Add support for finding hidden tokens (comments) #579
Merged
KevinEady
merged 2 commits into
ecompile-diagnostics
from
ecompile-diagnostics-hidden-tokens
Dec 21, 2023
Merged
Diagnostics: Add support for finding hidden tokens (comments) #579
KevinEady
merged 2 commits into
ecompile-diagnostics
from
ecompile-diagnostics-hidden-tokens
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Name formal parameters to differentiate between source locations in `VarStatement`.
frozenblit
approved these changes
Dec 21, 2023
KevinEady
added a commit
that referenced
this pull request
Dec 29, 2023
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Jan 29, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Jan 29, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Jan 29, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Jan 29, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Feb 3, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Feb 4, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Feb 6, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
KevinEady
added a commit
that referenced
this pull request
Feb 26, 2024
* Add support for hidden tokens * Address Discord review comments - Name formal parameters to differentiate between source locations in `VarStatement`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are stored as hidden tokens on the parser's token stream. In order to find the hidden tokens before a given token, access to the token stream is needed. The
SourceFile
is what keeps the parser, and the compilationsSourceFile
s are held by theBuilderWorkspace
in itssource_files
member.The
BuilderWorkspace
was a heap variable insideCompilerWorkspaceBuilder::build
but has now been moved to be a class member of the "root"CompilerWorkspace
, so applications can grab theSourceFile
for a given compiled file and callsf->get_hidden_tokens_before()
like so: