New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boat.set_alternate_multiid
#593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turleypol
approved these changes
Jan 9, 2024
turleypol
previously approved these changes
Jan 9, 2024
turleypol
approved these changes
Jan 10, 2024
KevinEady
added a commit
that referenced
this pull request
Jan 20, 2024
* Update maximum animation ID in configuration (#588) * Update maximum animation ID in configuration * updated core-changes * Change author name in corechanges.xml and core-changes.txt * updated pol.cfg docs * fix stylecheck test * removed useless comment * Added MaxAnimID to pol.cfg.example * New Kaitai version (#589) * updated Kaitai version, use shipped CMakeList. Added imported library target for easier integration * replaced debug CMakeList with original * Add support for boat piloting via mouse movement (#558) * Initial work on boat piloting changes - Changed: Boat script is now registered as the boat's control script - Added: Boat piloting via mouse movement - Added: boatRef.pilot member - Added: boatRef.pilot([charRef]) method * add first test * Fix boat control script attach on scripted create * move boat move packet warnings to suspicious acts * set pilot now errors when mutli has no process * Add test, testclient support for boat move packet * Touchup pilot members and methods - Change `pilot` method to `setpilot`. This standarizes it a bit with the same naming convention of `npc.setmaster`. - Fix return values in `pilot` member, returning `0` if no pilot. * Refactor to put functionality inside UBoat * Address Discord comments - Remove SuspecisionActs for no boat process. - Add `relative_direction` to boat move sysevent. * destroy boatmount on chr death; more error checks * Fix compilation after master merge * Fix relative_direction calculation * wip tests * Fix boat tests * Address review comments - Initialize UBoat::mountpiece * Add HSA check to boat.setpilot * Reject movement if boat mountpiece equipped * docs; test cleanup * add test for blocked movement * Address Discord review comments - Add suspicious acts notice for client movement while piloting - Return error on attempting to script move a char that is piloting a boat * Fix compiler warning * adapted gitignore for new kaitai (#590) * Allow custom boat control script defined in boat item descriptor; Rename boat method `setpilot` to `set_pilot` (#591) * Allow custom boat control script defined in boat item descriptor * Rename boat.setpilot to boat.set_pilot * Add `boat.set_alternate_multiid` (#593) * Fix unhandled exception in UBoat::create_component * Return 0 on unsuccessful boat move with MoveBoat and MoveBoatRelative * Add boat.set_alternate_multiid * skip base multiid in alternates boat struct * Add test for boat.set_alternate_id * docs, core-changes * use array equals in test * New format lib version (#592) * renamed include guard to be able to use both format lib versions in parallel * build Fmt lib and link it into clib * use std::string instead of format Writer for logging added variant "2" for logging with new fmt lib * use new logging variant for two logs * always add \n to flush log, lets see if the assumption holds * use new lib for tostring * replaced all INFO_PRINTS in clib * formatter for Token, BObject and BObjectImp * started with bsccript * use function instead of actual object for logging * remaining bscript, started plib * logvariant without newline added, more template magic * format support for base types, added test for format padding new version for fdump * chanhed ecompile/runecl fixed compilation with ESCRIPT_PROFILE * rewrite INFO_PRINT in plib,poltool/uoconvert/uotool * replaced remaining INFO_PRINTS, renamed macros INFO_PRINT for logging without newline, INFO_PRINTLN for newline addition. Replaced also INFO_PRINT_TRACE and renamed it to INFO_PRINTLN_TRACE * gitignore for fmt lib * cleanup vim leftovers * use new formatter for ERROR_PRINT, added ERROR_PRINTLN (#595) * use new formatter for ERROR_PRINT, added ERROR_PRINTLN * remove old log define * fix comments * Character buffs (#587) * Buffs: should be now possible to set for the first cliloc arguments, added chr.buffs member to return the current buffs * added test * docs * more docs * LEAKLOG, DEBUGLOG, SCRIPTLOG, FLEXLOG changed to new logging (#597) * LEAKLOG, DEBUGLOG, SCRIPTLOG changed to new logging * updated FLEXLOG * POLLOG* macros use the new formatting (#598) * POLLOG* macros use the new formatting removed all old logging functions * removed old fmt lib from everything except StreamWriter removed unneeded functions * fixed review comments * Prevent sending name on singleclick on hidden character (#599) * prevent sending name on singleclick on hidden character * Add core-changes --------- Co-authored-by: Kevin Eady <8634912+KevinEady@users.noreply.github.com> * Release POL 100.1.0 (#600) * Version bump to start work on v100.2.0 (#602) * Add `uninit`, `true`, `false` keywords to grammar (#596) * Update grammar * Update expression handling for uninit * update existing tests * Add new tests * Remove fullpath from escriptgrammar generation comment * fix tests * Update eScript guide * Declare escript version 0x11 * Add core-changes * Add `true` and `false` to grammar * true/false implementation * Fix existing tests * Add new tests * Update core changes * add docs * Fix BooleanValue::describe_to * bool optimizations * optimize uninit * remove unused var assignments * Update grammar for case labels for uninit, booleans * Fix case label handling for uninit, true, false * Tests * Fix compiler version display v1.1700000017881393 -> v1.17 * optimize boolean binary operations * fix unary boolean optimizer * add boolean, uninit optimizer test * Use new fmt lib apis * Fix compiler warning * really fix warning lol * Add Executor[Module]::getParam for bools, FindSubstance test * Fix PCH compilation --------- Co-authored-by: Vitor Lima <vitor@ferreiradelima.com> Co-authored-by: turleypol <turley@polserver.com> Co-authored-by: Lukáš Novotný <lukas@algorim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: