-
-
Notifications
You must be signed in to change notification settings - Fork 703
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tray: implement hiding functionality (#2723)
* tray hiding works * clang-format * Implemented suggestions
- Loading branch information
Showing
5 changed files
with
46 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2c5d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this commit, the tray icons start flickering it seems.
b2c5d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moson-mo Are you using picom or some other compositor?
b2c5d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. But if I run picom, the flickering actually stops :)
edit
It only seems to happen with the battery indicator icon from xfce4-power-manager.
The others are not flickering (like BT and Network)Others are flickering too. Somewhat depends on the position of a tray icon. The one on the very right flickers most.
edit2
Also when I run some fullscreen application like MPV, the tray bar stays visible (like always on-top)
b2c5d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moson-mo I just fixed a similar bug(#2742).
Can you test if that fixes it and otherwise file a proper bug report with minimal config?
b2c5d8e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raffael0 Tried that. It's still the same though.
Effectively nothing really changes with that patch I guess -> I do use the tray as a module to be able to place it between other modules.
Now when I remove the tray module and put `tray-position = right" there is no flickering...
I'll file a bug report later.
Anyways, thanks a lot for replying.