GitHub Actions CI #2284
Merged
GitHub Actions CI #2284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory returned was no longer valid because arg is destructed after the function returns.
For some reason when passing some non-const strings to convert, the convert(T&& arg) method was used instead of the one specialized for strings. This caused an error in clang because you can't pass objects with non-trivial types to varargs functions. The best solution I found was to just add a specialized function for non-const strings.
Codecov Report
@@ Coverage Diff @@
## hotfix/3.5.1 #2284 +/- ##
===============================================
- Coverage 7.33% 7.22% -0.11%
===============================================
Files 155 156 +1
Lines 10612 10707 +95
===============================================
- Hits 778 774 -4
- Misses 9834 9933 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
added a commit
that referenced
this pull request
Dec 12, 2020
Changelog **Features** * config: Multiple inheritance (#2271), see #2269 **Fixes** * (#2285), see #770, #2289 * Timer module: Polybar crash when interval is set to 0 (#2274), see #2273 * `custom/menu`: Wrong level numbers in error messages (#2264) * `internal/xworkspaces`: Ignored certain workspace updates (#2275), see #2272 * Logger: Undefined behavior (#2284) * build: * Build issues in older clang versions (#2270, #2279, #2280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This replaces travis CI with GitHub Actions. As I mentioned in #2278, we can't really use travis anymore because we ran out of credits. I have contacted the travis team, but I have not yet heard back 5 days later.
I decided to not use docker, even though it would make it easier to move CI to another provider, should we ever need/want to.
I think the overhead of having our own docker image is too high and if we just used for example the official ubuntu image, build times would be extremely high because we would need to install a bunch of packages everytime.
This also fixes some compilation issues that surfaced.
Related Issues & Documents
Closes #2278
Documentation (check all applicable)