Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add battery info to polychromatic-cli #398

Conversation

yoshida-ryuhei
Copy link
Contributor

@yoshida-ryuhei yoshida-ryuhei commented Jan 1, 2022

New feature

  • print information about battery by polychromatic-cli

Description

  • change Backend so that the data is transferred to polcychomatic-cli
  • print information about battery if it exists at polychromatic-cli

Motivation

I want to get the battery level by polychromatic-cli (not just GUI).

I don't understand the side effects and I haven't added any tests, so I'd like to know about that.

@lah7 lah7 added cli Specific to the command line application feature request New functionality that is wished for labels Jan 1, 2022
@lah7
Copy link
Member

lah7 commented Jan 1, 2022

Hi. This is awkward because I've been doing some refactoring across the project, so your changes will introduce a conflict. New WIP code is in the backend_refactor branch, and I have a few features to restore and fully test before it's ready to merge into master. I've had a short break working on the project.

One of the things I'm intending to do is create a battery class, so that the % can be exposed in the CLI and tray applet. I'm a dozen TODO's away, but I can work this into the new code when things are in a good state. ⚖️

@yoshida-ryuhei
Copy link
Contributor Author

Thank you for letting me know about the ongoing refactoring.
I am really looking forward to the refactoring going well, and I am going to wait for the new feature.

@lah7 lah7 changed the title [WIP] add battery info polychromatic-cli Add battery info to polychromatic-cli Jan 3, 2022
@lah7 lah7 marked this pull request as draft January 3, 2022 20:28
@lah7 lah7 self-assigned this Jan 3, 2022
lah7 added a commit that referenced this pull request Nov 2, 2022
Provides a central place to store and refresh battery data.

Addresses #398.
@lah7 lah7 closed this in e34ccc2 Nov 20, 2022
@lah7
Copy link
Member

lah7 commented Nov 20, 2022

Thanks for your patience, and sorry for taking so long.

The proposed feature has been re-implemented under the newer codebase: f8f51a6e1c80b30f6b45a24d4e4edf709ca0d239

@yoshida-ryuhei yoshida-ryuhei deleted the dev/add_battery_info_to_cli branch November 20, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Specific to the command line application feature request New functionality that is wished for
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants