-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Simplified Chinese Translation #514
Conversation
UM-Li
commented
May 4, 2024
•
edited
Loading
edited
- Corrected the alt-menu entries so that they work properly.
- Translated strings newly added since last time.
Oops I ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
谢谢 (Thank you!)
No problem about the other POT/PO files. For cleanness, I've taken them out of this pull request (to only show zh_CN.po
changes) and squashed your two commits into one. Here's a trick for next time:
git add locale/zh_CN.po
git commit -m "Update Simplified Chinese Translation"
In For me (in any other language), passing |
Hi @lah7, some strings do not show their translation here either (mine is a fully zh_CN.UTF-8 environment). For now all entries in |
Thanks for the info! There were a few bugs with how translations were processed, which have been fixed. These were mainly regressions from the v0.9.0 release. Would you be happy to pull the latest changes and check your translation? There will be new strings for the tray applet and CLI interfaces too ( After the translation is up-to-date, I'll look at publishing a new release. |
Thanks, great job! 👍🏼 I made some attempts locally to try and accommodate the wider characters using code, but I didn't feel satisfied with the result without impacting other languages (mostly it ends up too wide in
This is what I was experimenting with → 30efc7e. I am wondering about discontinuing the CLI interface in future, so we shouldn't spend too long on this. For now, the simplest solution seems to be adding additional spaces at the end of the translated string for this affected area. What do you think? #: polychromatic-cli:385 polychromatic-cli:388 polychromatic-cli:391
#: polychromatic/controller/devices.py:933
msgid "Custom Effects"
-msgstr "自定义灯效"
+msgstr "自定义灯效 " |
Yes, tested in my environment too and this works 👍 |