Network Monitor #146
Closed
Network Monitor #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add datamodel draft add stub for service datamodel: use uint64 everywhere, since float are not supported by yang and decimal64 are not supported by our codegen toolchain Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
to return pseudo random numebers Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>
|
@mbertrone This seems to be a nice feature. Will it be applied to the framework; like all the polycube services benefit from this or only specific services? Thanks! @frisso I recommend keeping this on hold before we merge to master, as this isn't a fully functional feature. Do you share the same thought? |
|
mauriciovasquezbernal
approved these changes
Jun 7, 2019
IMHO, We may first have it working in separate branch. Please do let me know If you still think otherwise. Thanks! |
acloudiator
requested changes
Jun 10, 2019
There was a problem hiding this comment.
@mbertrone can you please point to any test case or result to validate this feature? I don't see it here in any document. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a transparent service called
Network Monitor.The purpose of this module is collecting info over a link, that can be used by a remote backend server to detect attacks and anomalies.
Note: right now the implementation is not fully completed; the module is returning pseudo-random metrics.