Polyfill 404 craches app #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2015 18:04
add try catch to request(polyfill.url) return empty string if status != 200
|
adding you to the org so you can help maintain it :) thanks |
|
@jonathanong thanks for adding me to the team. How do you go about whit pull requests? What is your workflow |
| }).then(function (js) { | ||
| var text; | ||
| try { | ||
| assert(response.status === 200, polyfill.name + ': ' + response.status); |
There was a problem hiding this comment.
The real issue here is if a polyfill not returning a 200 then we wont get it.
And that might cause the users code to break further down.
So we need to catch it in some way and alert the user that a polyfill is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add try catch to request(polyfill.url)
return empty string if status != 200