Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of host/refreshInterval using url parameters. #7

Merged
merged 2 commits into from
Nov 3, 2013

Conversation

olimcc
Copy link

@olimcc olimcc commented Nov 2, 2013

Useful if you're not hosting the plugin with your cluster.

The commit looks larger than it is simply because of some excess whitespace that was in the file - let me know if this is a problem!

Oli McCormack added 2 commits November 2, 2013 15:46
Support specifying host/refreshInterval via url arguments. Example:
  http://localhost:8000/_site/#/myindex/?host=my-es-host.com:9200&refreshInterval=500
@polyfractal
Copy link
Owner

Does this cover a use-case that the "change host" button doesn't? Or is it just a convenience flag so you don't have to change the host each time (e.g. just bookmark the URI)?

(NP about the whitespace, happy those are gone anyhow :) )

@olimcc
Copy link
Author

olimcc commented Nov 3, 2013

It's primarily a convenience if you don't host the plugin with elasticsearch but still want to be able to link directly to an immediately working set of charts, without requiring people to input anything (both cases are true for me!). Where I work we have a url shortening service, so it's convenient to be able to put these settings in a url and have it just work.

I use bigdesk in a similar way so to some extent was just mimicking what they provided.

@polyfractal
Copy link
Owner

Sounds perfectly reasonable to me, thanks for the explanation! Merging right now

polyfractal added a commit that referenced this pull request Nov 3, 2013
Allow setting of host/refreshInterval using url parameters.
@polyfractal polyfractal merged commit 51fda94 into polyfractal:master Nov 3, 2013
@olimcc
Copy link
Author

olimcc commented Nov 3, 2013

Thanks Zachary! Great tool, now I can share the fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants