wasm support, bugfixes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved `hostname` lib behind conditional compiling - provided alternative implementation of hostname::get for wasm-targets
improve code structure
This reverts commit 584fd21.
* Give tungstenite types distinct names * reorganize files * Better feature locking, add wasm.rs * Implement wasm Backend * add wasm-bindgen-test * Build & Test for wasm * Add macos safari wasm test * Add wasm32 target * Add wasm.rs test * Move wasm-pack installation before test execution * Fix build on wasm32 * Fix examples depending on tokio::time * fix clippy warn * Add example wasm bindgen test * Add wasm-bindgen to Cargo.toml * Add wasm test configuration * Install wasm-bindgen-cli on linux * Add wasm-bindgen-cli to macos * Correct "vers" to "version" * Attempt to locate correct geckodriver * Run wasm tests first * maybe this will fix ci :clueless: * Move wasm-bindgen-cli install * Add cargo-binstall installation script for wasm-bindgen-cli * Try using only one browser * remove geckodriver * Move all wasm related tests to macos * Rename macOS test step for clarity * Try out combined coverage report * try different strategy to skip coverage on forks * Revert "try different strategy to skip coverage on forks" This reverts commit cae64ae. * Revert "Try out combined coverage report" This reverts commit 584fd21.
generate_general_configuration_schema_wasm
This reverts commit f0a4fe6.
This reverts commit 325c3d3.
This PR applies the necessary patches to correctly pass (all but two) tests when compiling for wasm32-unknown-unknown. 2 tests have been disabled for wasm at the moment: test messages::search_messages and test messages::send_message_attachment. These two tests currently rely on `std::fs` to grab a file to send/search for using chorus. This is not possible on wasm32-unknown, because this target does not have a Filesystem, and does not emulate on either. These two tests should be patched, but this should be good enough for now.
versions 0.12.0 and up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #430 and enables full support for the
wasm32-unknown-unknowncompilation target, making chorus the first(?) Rust Discord-API implementation to support this target.