Cache the results of cmake_parse_arguments where appropriate. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some cases where cmake_parse_arguments was being called with the same arguments hundreds of times. These are easy candidates for a cache table. This should reduce test runtime by about 20-30%.
smspillaz
force-pushed
the
cmake-unit.item_68
branch
from
ed2e8e7
to
7b0694a
Compare
smspillaz
force-pushed
the
cmake-unit.item_68
branch
from
7b0694a
to
aed5477
Compare
smspillaz
force-pushed
the
cmake-unit.item_68
branch
2 times, most recently
from
01c42db
to
7b0694a
Compare
smspillaz
added a commit
that referenced
this pull request
Feb 7, 2015
Cache the results of cmake_parse_arguments where appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some cases where cmake_parse_arguments was being
called with the same arguments hundreds of times. These are easy
candidates for a cache table. This should reduce test runtime
by about 20-30%.