Support Windows #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smspillaz
force-pushed
the
polysquare-setuptools-lint.item_9
branch
5 times, most recently
from
f8837e6
to
472019d
Compare
On Windows it is a backslash, which if left unescaped in a regex can cause all sorts of havoc.
There's some bugs in the Windows implementation.
Frosted reports inaccurate paths in its error messages on Windows, which messes up the suppressions logic.
Also don't run multiprocessing if the host CPU count is less than two - doing so would be pure overhead in that case.
Windows requires that nobody be inside a directory before it is deleted.
smspillaz
force-pushed
the
polysquare-setuptools-lint.item_9
branch
2 times, most recently
from
485ebfa
to
bd9120e
Compare
smspillaz
force-pushed
the
polysquare-setuptools-lint.item_9
branch
from
bd9120e
to
7d13469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes mainly involve judicious use of multiprocessing,
disabling linters which are known to be broken on Windows and
ensuring that files are not in use before they are deleted.