Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making protein features more visible #2218

Closed
2 tasks done
ValWood opened this issue Aug 27, 2024 · 28 comments
Closed
2 tasks done

Making protein features more visible #2218

ValWood opened this issue Aug 27, 2024 · 28 comments

Comments

@ValWood
Copy link
Member

ValWood commented Aug 27, 2024

  • 1. Change tab label in query builder to "protein features" (from protein motifs)
  1. Add TM domains to the Examples help text (under search box)
  • 3. Add a commonly user query for ALL protein features (motifs, signal sequences and TM domains)
@kimrutherford kimrutherford self-assigned this Aug 27, 2024
@kimrutherford
Copy link
Member

Add a commonly user query for ALL protein features (motifs, signal sequences and TM domains)

Do we want everything with a SO term?: https://www.pombase.org/term/SO:0000001

kimrutherford added a commit to pombase/pombase-config that referenced this issue Aug 28, 2024
kimrutherford added a commit to pombase/pombase-config that referenced this issue Aug 28, 2024
kimrutherford added a commit to pombase/pombase-config that referenced this issue Aug 28, 2024
@kimrutherford

This comment was marked as resolved.

@kimrutherford
Copy link
Member

Change tab label in query builder to "protein features" (from protein motifs)

Done

Add TM domains to the Examples help text (under search box)

Done. I added "TM domains, " but if you search for that string it doesn't found anything useful. Maybe we should change the text to "transmembrane helix"?

@ValWood

This comment was marked as resolved.

@ValWood

This comment was marked as outdated.

@kimrutherford
Copy link
Member

can we make it like this?
https://www.pombase.org/term_genes/SO:0000839

Linking to that page from the commonly used queries will take a bit of work because it's not a standard results page.

But if we add the SO term ID to the query description, it will be clickable link to that page:

image

It that enough?

@ValWood

This comment was marked as outdated.

@ValWood

This comment was marked as outdated.

@kimrutherford
Copy link
Member

Actually linking directly to
https://www.pombase.org/term/SO:0000839
would be even better (i.e shows the subsets)

Perhaps we could have that link in a different list? It feels wrong to have it in the list of commonly used queries since it's not a query - it's just a link to a term page.

@ValWood
Copy link
Member Author

ValWood commented Aug 28, 2024

That's true. Let's chat about it on Tuesday.

@ValWood
Copy link
Member Author

ValWood commented Sep 4, 2024

Thoughts

  1. I'm not sure how useful this list is if it can't be used to access the subsets, so maybe we don't require this (because its such a heterogenous bin)"commonly query".
  • 2. It seems slightly odd to have 2 separate ways to search fro TM domains (under TM domains or with the SO term), but maybe this is OK

resolve by removing "transmembrane domain" prompts from the SO search

  • 3. should "signal sequence" in the prompts be "signal peptide" (name)

  • 4. should we add "transit peptide" to the under the box prompt

  • 5. Actually when I search on "transit peptide" or "transit_peptide" in "protein features" I don't locate
    SO:0000725 , and although SO:0000725 is recognised by the search it give no results?
    (resolved by providing exact term name for searching)

  • 6. Examples: short motifs such as TM domains, NLS or KEN box, signal sequence, cleaved region, helix
    -> Examples: NLS or KEN box, signal sequence, cleaved region, transit peptide helix (I don't think helix is in here)

@ValWood
Copy link
Member Author

ValWood commented Sep 4, 2024

OK (Re point 5 and 6) we used mitochondrial_targeting_signal (SO:0001808)
because we thought it would be a more meaningful label so the prompt would need to be
"mitochondrial targeting signal"

@ValWood ValWood added the display label Sep 4, 2024
@kimrutherford

This comment was marked as outdated.

@kimrutherford

This comment was marked as resolved.

@kimrutherford
Copy link
Member

We have "TM domains" and "helix" separately in the help text. Perhaps we can combine those to just "TM helix"?

@kimrutherford

This comment was marked as resolved.

kimrutherford added a commit to pombase/pombase-config that referenced this issue Sep 5, 2024
"signal peptide" is now "mitochondrial targeting signal" in the help
text for the query builder SO term search box.

Refs pombase/website#2218
@kimrutherford

This comment was marked as resolved.

kimrutherford added a commit to pombase/pombase-config that referenced this issue Sep 5, 2024
Keep "mitochondrial targeting signal" but restore "signal peptide" to
the help prompt.

Refs pombase/website#2218
@kimrutherford

This comment was marked as resolved.

@ValWood

This comment was marked as off-topic.

@ValWood

This comment was marked as outdated.

@ValWood

This comment was marked as outdated.

@ValWood
Copy link
Member Author

ValWood commented Sep 5, 2024

so
"transmembrane domain" (I don't think we need to distinguish the subtype at this juncture - but if we can import additional non redundant transmembrane domains from Uniprot we should (they should probably be completely non overlapping with the existing)

@ValWood

This comment was marked as outdated.

@ValWood

This comment was marked as off-topic.

@kimrutherford

This comment was marked as resolved.

@kimrutherford
Copy link
Member

I'll do that now.

After the change it's:

Examples: short motifs such as NLS or KEN box, signal peptide, mitochondrial targeting signal,
cleaved region

Are there any other important features we could mention? There's plenty of space if we need a longer list.

kimrutherford added a commit to pombase/pombase-config that referenced this issue Sep 6, 2024
@kimrutherford
Copy link
Member

That change is on pombase.org now. Can we close this?

@ValWood
Copy link
Member Author

ValWood commented Sep 6, 2024

Yep, thanks!

@ValWood ValWood closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants