Merged latest master from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: app.go context.go
Used to output: ``` -- 'name' -name option -name option%!(EXTRA string=Usage text) ``` Now: ``` --name [] `-name option -name option` Usage text ```
Add shortcut for version flag
string slice flag option formatting
Fix typo in godoc for Float64
Standardize import statements
Allow to detect optional flags
Subcommand example used non-existent function
Add a way to override the app help printer
Fixed typo in README
By utilizing struct zero value
Conflicts: app.go help.go
Less composition needed.
Adding support for multiple env var "cascade"
Fixed ShowSubcommandHelp
Allow writer to be set
Signed-off-by: David Wadden <dwadden@pivotal.io>
…multiple Feels like it may have been copied from StringSliceFlag or something, but update the output to be more consistent with other single value flags. Also added comments to the String and Apply functions.
Allow hiding of help flag without hiding help subcommand
Fix help text for generic flag to not insinuate that you can specify mul...
Windows doesn't recognize 's for wrapping values. "s should work on all systems.
Use double quotes in output for defaults
…ding Int Flags from envvars.
strconv.ParseInt should be used instead of strconv.ParseUint when readin...
To be consistent with what the stdlib flag package does.
Use 0 as the base when parsing ints
stop flag parsing after terminator --
Rather than passing the unparsed context (parent context) in whenever there are no subcommands.
Conflicts: app.go app_test.go
As discussed in issue #151, I modified the implementation to be simpler. I checked how to propagate err, being done with a scope trick. From our deferred function we cannot return a new value, so we override the "default" return value (err), declared on functions' declarations. Check this StackOverflow for more info: http://stackoverflow.com/a/19934989
Use parsed context when running command as subcommnd
Fix sentence
After: companion action for Before
pombredanne
added a commit
that referenced
this pull request
Feb 25, 2015
Merged latest master from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.