redis: fix deletion versioning (#1871)

pomerium · Feb 9, 2021 · db3814e · db3814e
1 parent b9faff7
commit db3814e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/storage/redis/redis.go b/pkg/storage/redis/redis.go
@@ -116,6 +116,7 @@ func (db *DB) Delete(ctx context.Context, id string) (err error) {
 
 			// mark it as deleted
 			record.DeletedAt = timestamppb.Now()
+			record.Version = formatVersion(version)
 
 			return nil
 		},

diff --git a/pkg/storage/redis/redis_test.go b/pkg/storage/redis/redis_test.go
@@ -144,11 +144,14 @@ func testDB(t *testing.T) {
 		}
 	})
 	t.Run("delete record", func(t *testing.T) {
+		original, err := db.Get(ctx, id)
+		require.NoError(t, err)
 		assert.NoError(t, db.Delete(ctx, id))
 		record, err := db.Get(ctx, id)
 		require.NoError(t, err)
 		require.NotNil(t, record)
 		assert.NotNil(t, record.DeletedAt)
+		assert.NotEqual(t, original.GetVersion(), record.GetVersion())
 	})
 	t.Run("clear deleted", func(t *testing.T) {
 		db.ClearDeleted(ctx, time.Now().Add(time.Second))