Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis: fix deletion versioning #1871

Merged
merged 1 commit into from Feb 8, 2021
Merged

redis: fix deletion versioning #1871

merged 1 commit into from Feb 8, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

The redis implementation of the databroker is not currently incrementing the record version when a record is deleted. Because the version doesn't change, the record change isn't detected by sync and consumers will only pick up the change on restart.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the bug Something isn't working label Feb 8, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner February 8, 2021 22:16
@codeclimate
Copy link

codeclimate bot commented Feb 8, 2021

Code Climate has analyzed commit ae523e5 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #1871 (d468016) into master (a389139) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #1871     +/-   ##
========================================
- Coverage    59.5%   59.4%   -0.1%     
========================================
  Files         138     138             
  Lines        9643    9644      +1     
========================================
- Hits         5744    5735      -9     
- Misses       3302    3309      +7     
- Partials      597     600      +3     
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 74.2% <100.0%> (-1.0%) ⬇️
internal/controlplane/xdsmgr/xdsmgr.go 75.4% <0.0%> (-5.9%) ⬇️
internal/autocert/manager.go 65.5% <0.0%> (-1.4%) ⬇️

@calebdoxsey calebdoxsey merged commit b5d52ce into master Feb 8, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/639 branch February 8, 2021 23:12
github-actions bot pushed a commit that referenced this pull request Feb 9, 2021
travisgroth pushed a commit that referenced this pull request Feb 9, 2021
Co-authored-by: Caleb Doxsey <cdoxsey@pomerium.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 0-13-0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants