-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directory.Group entry for groups #1118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit f99de4f and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
desimone
reviewed
Jul 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #1118 +/- ##
========================================
- Coverage 55.4% 54.6% -0.8%
========================================
Files 100 100
Lines 7121 7251 +130
========================================
+ Hits 3951 3966 +15
- Misses 2865 2980 +115
Partials 305 305
|
desimone
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes how we store groups. We will now store a separate
directory.Group
entry in the databroker and thedirectory.User
groups
field has been renamed togroup_ids
. On evaluation we then look up the correspondingdirectory.Group
based on that ID.I updated all the directory providers to return this information and updated the manager to sync it accordingly. Other changes:
displayName
notname
.Related
(bdd edit)
Checklist: