Docs: Update README stating specific requirements for SIGNING_KEY #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes clear it must be an EC key and also that it must be present in the authentication service, if run separately.
|
|
|
Code Climate has analyzed commit 76258fa and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## master #1217 +/- ##
======================================
Coverage 59.0% 59.1%
======================================
Files 102 102
Lines 7661 7661
======================================
+ Hits 4525 4528 +3
+ Misses 2742 2739 -3
Partials 394 394
|
desimone
approved these changes
Aug 5, 2020
desimone
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
@bradjones1 LGTM. Thanks for specifying that. We sort of gloss over the althorithim requirements in https://www.pomerium.io/docs/reference/getting-users-identity.html#prerequisites
(I'd like to support ed in the near future, but RSA is just too slow).
|
@bradjones1 Do you mind signing the contributor agreement? Otherwise, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes clear it must be an EC key and also that it must be present in the authentication service, if run separately.
Checklist: