Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix profile image on dashboard #1637

Merged
merged 1 commit into from
Dec 1, 2020
Merged

fix profile image on dashboard #1637

merged 1 commit into from
Dec 1, 2020

Conversation

calebdoxsey
Copy link
Contributor

Summary

GetClaim returns a list instead of a single value. This fixes the dashboard so that it uses range instead of with as well as passing it through safeURL.

Related issues

Checklist:

  • add related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner November 30, 2020 23:33
@codeclimate
Copy link

codeclimate bot commented Nov 30, 2020

Code Climate has analyzed commit f6f75f0 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #1637 (f6f75f0) into master (3f7777f) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #1637     +/-   ##
========================================
- Coverage    55.5%   55.5%   -0.1%     
========================================
  Files         126     126             
  Lines        9156    9156             
========================================
- Hits         5086    5085      -1     
- Misses       3577    3580      +3     
+ Partials      493     491      -2     
Impacted Files Coverage Δ
pkg/storage/redis/redis.go 70.3% <0.0%> (-1.4%) ⬇️
internal/autocert/manager.go 64.4% <0.0%> (+1.4%) ⬆️

@calebdoxsey calebdoxsey merged commit b121e43 into master Dec 1, 2020
@calebdoxsey calebdoxsey deleted the cdoxsey/1604 branch December 1, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authenticate: dashboard returns malformed user gravatar
2 participants