Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ping: add documentation #1976

Merged
merged 4 commits into from
Mar 12, 2021
Merged

ping: add documentation #1976

merged 4 commits into from
Mar 12, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add documentation for the new Ping provider.

Related issues

Fixes #1975

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the docs Docs update required label Mar 11, 2021
@calebdoxsey calebdoxsey requested a review from a team as a code owner March 11, 2021 19:39
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #1976 (4f00ed0) into master (fd97561) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1976   +/-   ##
======================================
  Coverage    60.2%   60.2%           
======================================
  Files         151     151           
  Lines       10364   10364           
======================================
+ Hits         6248    6249    +1     
  Misses       3458    3458           
+ Partials      658     657    -1     
Impacted Files Coverage Δ
pkg/storage/inmemory/backend.go 86.7% <0.0%> (-3.7%) ⬇️
internal/databroker/server.go 50.7% <0.0%> (-1.0%) ⬇️
internal/databroker/config_source.go 56.0% <0.0%> (+1.7%) ⬆️
internal/controlplane/xdsmgr/xdsmgr.go 81.3% <0.0%> (+3.9%) ⬆️

Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM. Few minor suggestions.

docs/docs/identity-providers/ping.md Outdated Show resolved Hide resolved
docs/docs/identity-providers/ping.md Outdated Show resolved Hide resolved
docs/docs/identity-providers/ping.md Outdated Show resolved Hide resolved
calebdoxsey and others added 3 commits March 12, 2021 09:01
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
Co-authored-by: bobby <1544881+desimone@users.noreply.github.com>
@calebdoxsey calebdoxsey merged commit 07e150a into master Mar 12, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/ping-docs branch March 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants