Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: use getters for authenticate, signout and forward auth urls #2000

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

calebdoxsey
Copy link
Contributor

Summary

As part of removing side-effects from config option validation, this PR uses Get... methods for AuthenticateURL, SignOutURL and ForwardAuthURL.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner March 19, 2021 18:44
@calebdoxsey calebdoxsey requested a review from wasaga March 19, 2021 18:44
@codeclimate
Copy link

codeclimate bot commented Mar 19, 2021

Code Climate has analyzed commit dfa01fb and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #2000 (dfa01fb) into master (1febaa8) will decrease coverage by 0.0%.
The diff coverage is 50.7%.

@@           Coverage Diff            @@
##           master   #2000     +/-   ##
========================================
- Coverage    59.7%   59.6%   -0.1%     
========================================
  Files         154     154             
  Lines       10565   10593     +28     
========================================
+ Hits         6310    6318      +8     
- Misses       3547    3559     +12     
- Partials      708     716      +8     
Impacted Files Coverage Δ
authorize/authorize.go 64.7% <0.0%> (ø)
internal/autocert/manager.go 65.9% <0.0%> (-1.0%) ⬇️
internal/controlplane/xds_routes.go 73.9% <0.0%> (ø)
proxy/state.go 84.2% <33.3%> (-4.7%) ⬇️
proxy/handlers.go 91.1% <42.8%> (-2.0%) ⬇️
authenticate/state.go 77.6% <50.0%> (-2.1%) ⬇️
authorize/evaluator/evaluator.go 57.9% <50.0%> (-0.6%) ⬇️
proxy/proxy.go 74.4% <55.5%> (-6.5%) ⬇️
authenticate/handlers.go 83.9% <60.0%> (-0.5%) ⬇️
config/options.go 46.1% <60.0%> (-0.4%) ⬇️
... and 5 more

@calebdoxsey calebdoxsey merged commit 3690a32 into master Mar 19, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/config-url-strings branch March 19, 2021 20:49
travisgroth added a commit to travisgroth/pomerium that referenced this pull request Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants