Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptutil: use bytes for hmac #2067

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Conversation

calebdoxsey
Copy link
Contributor

Summary

Update the HMAC methods in cryptutil to takes []byte instead of string. Also update the signed URL to take in []byte.

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested a review from a team as a code owner April 7, 2021 19:48
@calebdoxsey calebdoxsey requested a review from wasaga April 7, 2021 19:48
@codeclimate
Copy link

codeclimate bot commented Apr 7, 2021

Code Climate has analyzed commit b3b4004 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #2067 (b3b4004) into master (9de340b) will increase coverage by 0.0%.
The diff coverage is 80.0%.

@@          Coverage Diff           @@
##           master   #2067   +/-   ##
======================================
  Coverage    59.4%   59.4%           
======================================
  Files         167     167           
  Lines       11233   11278   +45     
======================================
+ Hits         6675    6707   +32     
- Misses       3780    3793   +13     
  Partials      778     778           
Impacted Files Coverage Δ
internal/middleware/middleware.go 100.0% <ø> (ø)
internal/urlutil/signed.go 92.7% <ø> (ø)
authenticate/middleware.go 54.5% <50.0%> (ø)
authenticate/handlers.go 82.4% <66.6%> (ø)
authorize/check_response.go 81.6% <100.0%> (ø)
internal/httputil/reproxy/reproxy.go 77.1% <100.0%> (ø)
pkg/cryptutil/hmac.go 100.0% <100.0%> (ø)
proxy/state.go 84.6% <100.0%> (ø)
internal/databroker/config_source.go 51.1% <0.0%> (-4.9%) ⬇️
pkg/storage/inmemory/backend.go 86.7% <0.0%> (-3.7%) ⬇️
... and 4 more

@calebdoxsey calebdoxsey merged commit a51c714 into master Apr 7, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/349-crypto-bytes branch April 7, 2021 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants