ppl: refactor authorize to evaluate PPL #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 5df492a and detected 0 issues on this pull request. View more on Code Climate. |
desimone
reviewed
May 19, 2021
desimone
reviewed
May 19, 2021
desimone
reviewed
May 19, 2021
desimone
reviewed
May 20, 2021
desimone
reviewed
May 20, 2021
desimone
reviewed
May 20, 2021
desimone
reviewed
May 20, 2021
calebdoxsey
commented
May 20, 2021
wasaga
approved these changes
May 21, 2021
| h := make(http.Header) | ||
|
|
||
| m, ok := vars["result"].(map[string]interface{}) | ||
| if !ok { |
There was a problem hiding this comment.
shouldn't this an others below be an error that should bubble up from Evaluate?
There was a problem hiding this comment.
I don't think so. I can make this change if you want but I suspect we'll have to roll it back. There may be valid reasons why no allow or deny block occurs in the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the authorize evaluator to use PPL instead of
authz.rego.Checklist
improvement/bug/ etc)