-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppl: refactor authorize to evaluate PPL #2224
Conversation
Code Climate has analyzed commit 5df492a and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. A few questions and comments.
It looks like half of my review comments were sent as vanilla comments. Sorry about that.
h := make(http.Header) | ||
|
||
m, ok := vars["result"].(map[string]interface{}) | ||
if !ok { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this an others below be an error that should bubble up from Evaluate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. I can make this change if you want but I suspect we'll have to roll it back. There may be valid reasons why no allow
or deny
block occurs in the result.
Summary
Update the authorize evaluator to use PPL instead of
authz.rego
.Checklist
improvement
/bug
/ etc)