Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/envoyconfig: better duplicate message #2661

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

desimone
Copy link
Contributor

@desimone desimone commented Oct 4, 2021

Summary

Clearer error message for duplicate routes.

Related issues

Fixes #2655

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@desimone desimone requested a review from a team as a code owner October 4, 2021 16:39
@codeclimate
Copy link

codeclimate bot commented Oct 4, 2021

Code Climate has analyzed commit 0237d75 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 64.751% when pulling 0237d75 on desimone/better-duplicate-route-message into b47d428 on master.

@desimone desimone enabled auto-merge (squash) October 4, 2021 22:42
@desimone desimone merged commit 45ce202 into master Oct 4, 2021
@desimone desimone deleted the desimone/better-duplicate-route-message branch October 4, 2021 23:37
alexfornuto pushed a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better message of the error if route is duplicated
3 participants