Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: remove peer field from logs #2712

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

calebdoxsey
Copy link
Contributor

Summary

Remove the peer field from gRPC logs. Since moving outbound connections to Envoy, the peer field always shows 127.0.0.1, which isn't useful.

Related issues

Fixes https://github.com/pomerium/internal/issues/571

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@codeclimate
Copy link

codeclimate bot commented Oct 26, 2021

Code Climate has analyzed commit 9ed1b2c and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 65.101% when pulling 9ed1b2c on cdoxsey/571-grpc-peer-field into 97dfb7c on master.

@calebdoxsey calebdoxsey merged commit b2c76c3 into master Oct 26, 2021
@calebdoxsey calebdoxsey deleted the cdoxsey/571-grpc-peer-field branch October 26, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants