envoyconfig: prevent nil reproxy handler #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdoxsey
approved these changes
May 11, 2022
backport-actions-token bot
pushed a commit
that referenced
this pull request
May 11, 2022
(cherry picked from commit a15106e)
calebdoxsey
pushed a commit
that referenced
this pull request
May 11, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reproxy handler is set to nil during config validation in the console and ingress controller,
that would result in SIGSEGV if
kubernetes_service_account_tokenconfig option is set.as
reproxypackage is internal, a fix is to prevent a nil reproxy.Related issues
pomerium/ingress-controller#205
Checklist
improvement/bug/ etc)