netutil: improve port allocation #3432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasaga
reviewed
Jun 17, 2022
internal/netutil/netutil.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| return ports, err |
internal/netutil/netutil.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| return ports, err |
There was a problem hiding this comment.
Same; not all ports would be allocated yet we return them?
wasaga
approved these changes
Jun 17, 2022
|
Still broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes we seem to allocate an invalid port which causes tests to fail: https://github.com/pomerium/pomerium/runs/6923304146?check_suite_focus=true
This PR updates the port allocation code to hopefully use a more reliable approach.
Checklist
improvement/bug/ etc)