config: default to http2 #3660
Merged
config: default to http2 #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we defaulted to
http1when in all-in-one mode. This PR updates the code so that we default tohttp2instead.The original behavior was because we did not add routes to all virtual hosts resulting in 421s when requests were coalesced on the same HTTP/2 connection. We now can handle these routes, so there's no need to return the 421s anymore.
Related issues
Fixes https://github.com/pomerium/internal/issues/1010
Checklist
improvement/bug/ etc)