Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: wildcard catch-all cert must be at the end of cert list #4119

Merged
merged 1 commit into from Apr 21, 2023
Merged

tls: wildcard catch-all cert must be at the end of cert list #4119

merged 1 commit into from Apr 21, 2023

Conversation

wasaga
Copy link
Contributor

@wasaga wasaga commented Apr 21, 2023

Summary

Wildcard catch-all "*" cert must be at the very bottom of cert list so that it'll get matched last.

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner April 21, 2023 15:41
@wasaga wasaga requested a review from calebdoxsey April 21, 2023 15:41
@coveralls
Copy link

Coverage Status

Coverage: 63.334% (+0.05%) from 63.282% when pulling 65e0fcb on wasaga/wildcard-to-end into 681cf6f on main.

@wasaga wasaga added the bug Something isn't working label Apr 21, 2023
@wasaga wasaga merged commit 34c1e44 into main Apr 21, 2023
13 checks passed
@wasaga wasaga deleted the wasaga/wildcard-to-end branch April 21, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebdoxsey calebdoxsey calebdoxsey approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wasaga @coveralls @calebdoxsey