Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: wildcard catch-all cert must be at the end of cert list #4119

Merged
merged 1 commit into from Apr 21, 2023
Merged

tls: wildcard catch-all cert must be at the end of cert list #4119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@
.*.yaml
.*.json
.*.rego
*.jq
pem
env
coverage.txt
Expand Down
4 changes: 1 addition & 3 deletions config/envoyconfig/listeners.go
View file
Open in desktop
Expand Up @@ -114,9 +114,7 @@ func getAllCertificates(cfg *config.Config) ([]tls.Certificate, error) {
return nil, fmt.Errorf("error getting wildcard certificate: %w", err)
}

// wildcard certificate must be first so that it is used as the default certificate
// when no SNI matches
return append([]tls.Certificate{*wc}, allCertificates...), nil
return append(allCertificates, *wc), nil
}

func (b *Builder) buildTLSSocket(ctx context.Context, cfg *config.Config, certs []tls.Certificate) (*envoy_config_core_v3.TransportSocket, error) {
Expand Down