Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unnecessary use of fmt.Sprintf #4349

Merged
merged 1 commit into from Jul 12, 2023
Merged

chore: unnecessary use of fmt.Sprintf #4349

merged 1 commit into from Jul 12, 2023

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Jul 11, 2023

Summary

Remove fmt.Sprintf() calls where the format string contains no formatting verbs.

Related issues

User Explanation

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@testwill testwill requested a review from a team as a code owner July 11, 2023 09:16
@CLAassistant
Copy link

CLAassistant commented Jul 11, 2023

CLA assistant check
All committers have signed the CLA.

@kenjenkins
Copy link
Contributor

Thanks for your contribution! Would you mind editing the PR description above to fill out the 'Summary' section? Maybe something like "Remove fmt.Sprintf() calls where the format string contains no formatting verbs."?

@coveralls
Copy link

Coverage Status

coverage: 63.521% (+0.07%) from 63.456% when pulling 83b7284 on testwill:fmt into 5459e69 on pomerium:main.

@kenjenkins kenjenkins merged commit 4674b98 into pomerium:main Jul 12, 2023
9 of 10 checks passed
@testwill testwill deleted the fmt branch July 13, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants