Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unnecessary use of fmt.Sprintf #4349

Merged
merged 1 commit into from Jul 12, 2023
Merged

chore: unnecessary use of fmt.Sprintf #4349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions authenticate/handlers_test.go
View file
Open in desktop
Expand Up @@ -60,7 +60,7 @@ func TestAuthenticate_RobotsTxt(t *testing.T) {
if status := rr.Code; status != http.StatusOK {
t.Errorf("handler returned wrong status code: got %v want %v", status, http.StatusOK)
}
expected := fmt.Sprintf("User-agent: *\nDisallow: /")
expected := "User-agent: *\nDisallow: /"
if rr.Body.String() != expected {
t.Errorf("handler returned wrong body: got %v want %v", rr.Body.String(), expected)
}
Expand All @@ -78,7 +78,7 @@ func TestAuthenticate_Handler(t *testing.T) {

rr := httptest.NewRecorder()
h.ServeHTTP(rr, req)
expected := fmt.Sprintf("User-agent: *\nDisallow: /")
expected := "User-agent: *\nDisallow: /"

body := rr.Body.String()
if body != expected {
Expand All @@ -92,7 +92,7 @@ func TestAuthenticate_Handler(t *testing.T) {
req.Header.Set("Access-Control-Request-Headers", "X-Requested-With")
rr = httptest.NewRecorder()
h.ServeHTTP(rr, req)
expected = fmt.Sprintf("User-agent: *\nDisallow: /")
expected = "User-agent: *\nDisallow: /"
code := rr.Code
if code/100 != 2 {
t.Errorf("bad preflight code %v", code)
Expand Down
4 changes: 2 additions & 2 deletions pkg/cryptutil/hmac_test.go
View file
Open in desktop
Expand Up @@ -56,8 +56,8 @@ func TestValidTimestamp(t *testing.T) {
{"good - now + 200ms", fmt.Sprint(time.Now().Add(200 * time.Millisecond).Unix()), false},
{"bad - now + 10m", fmt.Sprint(time.Now().Add(10 * time.Minute).Unix()), true},
{"bad - now - 10m", fmt.Sprint(time.Now().Add(-10 * time.Minute).Unix()), true},
{"malformed - non int", fmt.Sprint("pomerium"), true},
{"malformed - negative number", fmt.Sprint("-1"), true},
{"malformed - non int", "pomerium", true},
{"malformed - negative number", "-1", true},
{"malformed - huge number", fmt.Sprintf("%d", 10*10000000000), true},
}
for _, tt := range tests {
Expand Down