Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix cookie_domain #472

Merged
merged 1 commit into from
Jan 28, 2020
Merged

docs: fix cookie_domain #472

merged 1 commit into from
Jan 28, 2020

Conversation

nitper
Copy link
Contributor

@nitper nitper commented Jan 28, 2020

Summary

The config vars for cookie domain are incorrect.

Checklist:

  • updated docs
  • ready for review

@claassistantio
Copy link

claassistantio commented Jan 28, 2020

CLA assistant check
All committers have signed the CLA.

@codeclimate
Copy link

codeclimate bot commented Jan 28, 2020

Code Climate has analyzed commit b9ee0b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.3% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #472 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #472   +/-   ##
======================================
  Coverage    87.4%   87.4%           
======================================
  Files          53      53           
  Lines        2663    2663           
======================================
  Hits         2328    2328           
  Misses        255     255           
  Partials       80      80

Copy link
Contributor

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nitper good catch.

@desimone desimone added the docs Docs update required label Jan 28, 2020
@desimone desimone merged commit 6a10112 into pomerium:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants