Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move events.go out of internal/authenticateflow #4852

Merged
merged 2 commits into from
Dec 12, 2023
Merged

move events.go out of internal/authenticateflow #4852

merged 2 commits into from
Dec 12, 2023

Commits on Dec 12, 2023

  1. move events.go out of internal/authenticateflow 

    Commit b7896b3 moved events.go from the 'authenticate' package to
'internal/authenticateflow' in order to avoid an import cycle. However
this location is not actually suitable, as the hosted authenticate
service refers to AuthEvent and AuthEventFn.

Move events.go back out from under 'internal', to a new package
'authenticate/events'. This should still avoid an import cycle between
'authenticate' and 'internal/authenticateflow', while also allowing the
hosted authenticate service to use the events types.
    @kenjenkins
    kenjenkins committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    e0b2a58 View commit details
    Browse the repository at this point in the history

  2. add package comment

    @kenjenkins
    kenjenkins committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    da6af74 View commit details
    Browse the repository at this point in the history