move events.go out of internal/authenticateflow #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit b7896b3 moved events.go from the 'authenticate' package to 'internal/authenticateflow' in order to avoid an import cycle. However this location is not actually suitable, as the hosted authenticate service refers to AuthEvent and AuthEventFn. Move events.go back out from under 'internal', to a new package 'authenticate/events'. This should still avoid an import cycle between 'authenticate' and 'internal/authenticateflow', while also allowing the hosted authenticate service to use the events types.
calebdoxsey
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Commit b7896b3 moved events.go from the 'authenticate' package to 'internal/authenticateflow' in order to avoid an import cycle. However this location is not actually suitable, as the hosted authenticate service refers to
AuthEventandAuthEventFn.Move events.go back out from under 'internal', to a new package 'authenticate/events'. This should still avoid an import cycle between 'authenticate' and 'internal/authenticateflow', while also allowing the hosted authenticate service to use the events types.
Related issues
User Explanation
Checklist
improvement/bug/ etc)