controlplane: avoid calling Close on nil listener #5156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tweak the cleanup logic in controlplane.NewServer(). Following the pattern of the other two
net.Listen
calls I think the intent was to callMetricsListener.Close()
if theDebugListener
fails to start, rather thanDebugListener.Close()
.There was a nil panic from this line in a recent integration test run:
https://github.com/pomerium/pomerium/actions/runs/9688646705/job/26735594932?pr=5155#step:8:74
Related issues
User Explanation
Checklist
improvement
/bug
/ etc)