internal/identity: google cannot have both approval_prompt and prompt #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
=======================================
Coverage 79.21% 79.21%
=======================================
Files 31 31
Lines 1828 1828
=======================================
Hits 1448 1448
Misses 308 308
Partials 72 72 |
desimone
changed the title
gopherbot
pushed a commit
to golang/oauth2
that referenced
this pull request
May 23, 2019
…nsent It looks like in 2016 or so` approval_prompt=force` was replaced with the open id connect friendly `prompt=consent`. See: - https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest - https://developers.google.com/identity/sign-in/web/reference#gapiauth2offlineaccessoptions - googleapis/oauth2client#453 - pomerium/pomerium#82 Change-Id: Iad2d533f451a70b2941aafd11c9b7272026a2f16 GitHub-Last-Rev: d6d10ce GitHub-Pull-Request: #379 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/171123 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where caused by setting both
prompt=consentandapproval_prompt=force. Though approval_prompt seems to be legacy it is still in the oauth2 source code.See:
Checklist: