-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated #112
Comments
Well, it seems that this class is still defined as a service in https://github.com/pomm-project/pomm-bundle/blob/3.0.0/sources/lib/Resources/config/services/pomm.yml#L39 @stood I think we just have to remove that in the bundle. |
That's what I think. This class was supposed to be removed in v3.0 |
But symfony bridge was already in version 3, and deprecation is not removed? |
How is it blocking? Isn't it just a deprecation notice? The class itself is not used anymore, just declared in the service container, with a deprecation notice and a class_alias https://github.com/pomm-project/pomm-symfony-bridge/blob/3.0.0/sources/lib/PropertyInfo/Extractor/PommExtractor.php |
That's not blocking. But deprecation messages still appears without any reason. |
Sorry for the time of my answer. Thanks for your Pull Request, rdavaillaud |
…mm-project#113) (#11) Co-authored-by: Raphaël Davaillaud <548656+rdavaillaud@users.noreply.github.com>
Hi,
I use pomm-bundle in a Symfony 4.4 project. Since the 2.3 version of POMM, I have the following notice:
User Deprecated: The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated since version 2.3 and will be removed in 3.0. Use the PommProject\SymfonyBridge\PropertyInfo\Extractor\TypeExtractor class instead.
So I have upgraded pomm-bundle to version 3.0, but I still have this notice message.
Could you please give me an explanation ? Have I missed something and is there a way to avoid these notices ?
Thank you
The text was updated successfully, but these errors were encountered: