Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated #112

Closed
maximechagnolleau opened this issue Jun 10, 2021 · 6 comments

Comments

@maximechagnolleau
Copy link

Hi,

I use pomm-bundle in a Symfony 4.4 project. Since the 2.3 version of POMM, I have the following notice:

User Deprecated: The PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor class is deprecated since version 2.3 and will be removed in 3.0. Use the PommProject\SymfonyBridge\PropertyInfo\Extractor\TypeExtractor class instead.

So I have upgraded pomm-bundle to version 3.0, but I still have this notice message.

Could you please give me an explanation ? Have I missed something and is there a way to avoid these notices ?

Thank you

@rdavaillaud
Copy link
Contributor

Well, it seems that this class is still defined as a service in https://github.com/pomm-project/pomm-bundle/blob/3.0.0/sources/lib/Resources/config/services/pomm.yml#L39

@stood I think we just have to remove that in the bundle.

@maximechagnolleau
Copy link
Author

maximechagnolleau commented Jun 11, 2021

That's what I think. This class was supposed to be removed in v3.0

@Doud63
Copy link

Doud63 commented Jun 11, 2021

But symfony bridge was already in version 3, and deprecation is not removed?
This error is blocking

@rdavaillaud
Copy link
Contributor

How is it blocking? Isn't it just a deprecation notice?

The class itself is not used anymore, just declared in the service container, with a deprecation notice and a class_alias https://github.com/pomm-project/pomm-symfony-bridge/blob/3.0.0/sources/lib/PropertyInfo/Extractor/PommExtractor.php

@maximechagnolleau
Copy link
Author

That's not blocking. But deprecation messages still appears without any reason.

@Doud63
Copy link

Doud63 commented Jun 16, 2021

Sorry for the time of my answer.
I work in PHP 8, and i have this error in test environment
Error : Class "PommProject\SymfonyBridge\PropertyInfo\Extractor\PommExtractor" not found

Thanks for your Pull Request, rdavaillaud

@stood stood closed this as completed in ee4b0eb Jun 20, 2021
dougetovski pushed a commit to Conserto/pomm-bundle that referenced this issue Jan 3, 2024
…mm-project#113) (#11)

Co-authored-by: Raphaël Davaillaud <548656+rdavaillaud@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants