Naming schema #91
Closed
Naming schema #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 23, 2014 15:52
regexps as there is no need for that.
|
Thanks for creating this pull request. Unfortunately it won't be merged. Like explained in #44 I'm comfortable using a regex to cover the Naming Schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request follows collectd naming schema. Unfortunatelly I have no idea what is 'c' (category) key used for. In previous code I can see varnish in regexp. Plugin page does not mention anything unusual about naming schema.
Note:
This is not backwards compatible with collectd 4.x. Please see this for more information.