Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should functions and classes have an end? #36

Closed
andymcn opened this issue Sep 18, 2014 · 1 comment
Closed

Should functions and classes have an end? #36

andymcn opened this issue Sep 18, 2014 · 1 comment

Comments

@andymcn
Copy link
Contributor

andymcn commented Sep 18, 2014

All of our control structures terminate with the end keyword (if, while, try, etc). But methods and entities don't. This seems strange and inconsistent to me.

Making methods have a termiantor would also remove the ordering requirement for methods after fields.

@andymcn
Copy link
Contributor Author

andymcn commented Sep 22, 2014

After lengthy discussion, with examples, we've decided that no, methods and entities should not have ends.
For the record:
Sylvan and Sebastian both prefer not having them.
Andy prefers having them on multiline methods and entities, but agrees they are ugly for single line ones.

@andymcn andymcn closed this as completed Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant