Switch from pony-stable to corral #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanTAllen
force-pushed
the
stable-to-corral
branch
4 times, most recently
from
79f82ad
to
9cae344
Compare
|
@Theodus when you merge this, can you add a note to LWIP about how we are starting our dog-fooding of the transition from pony-stable to corral and perhaps a bit of background on that. Seems like a very good LWIP note. |
SeanTAllen
force-pushed
the
stable-to-corral
branch
from
9cae344
to
76b7899
Compare
SeanTAllen
commented
May 6, 2020
| @@ -1,8 +1,8 @@ | |||
| FROM ponylang/ponyup-ci-x86-64-unknown-linux-builder:release AS build | |||
There was a problem hiding this comment.
i can't even find the Dockerfile for this. It's so old. And it never existed in this repo. Oooops.
SeanTAllen
force-pushed
the
stable-to-corral
branch
3 times, most recently
from
e7982f5
to
542eee3
Compare
Pony-stable is deprecated. This is part of our move off of it. Corral supports transitive dependencies so we can go back and change the corral.json later when we add corral support to the dependencies we have listed. Closes #105
Theodus
reviewed
May 6, 2020
SeanTAllen
force-pushed
the
stable-to-corral
branch
from
542eee3
to
8effd6a
Compare
|
I am unable to reproduce the CI failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pony-stable is deprecated. This is part of our move off of it.
Corral supports transitive dependencies so we can go back and
change the corral.json later when we add corral support to the
dependencies we have listed.