Support filtering the subject line #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2014 10:39
Hide the unused strings and only show the configured menuitems.
Enable multibyte strings in title and body string
This avoids a few frequent troublemaker characters, based on prejudice and my org-mode use case (which breaks on brackets in the subject). This allow to use e.g. [[<thunderlink>][Email: <filteredSubject>]] as a nice org-mode link template that tends to actually work. Signed-off-by: Simon Thum <simon.thum@igd.fraunhofer.de>
|
This PR is for review and feedback mainly, please do not include the XPI commit in case you want to merge. For creating org-mode compatible links that contain the subject (github eats the relevant part of the commit message...) certain characters need to be filtered. My issue is whether ot make the characters filtered configurable - right now this is a bit of "my stuff", but doing so adds complexity. |
poohsen
pushed a commit
that referenced
this pull request
Dec 7, 2015
Support filtering the subject line. Thanks to all committers!
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a few frequent troublemaker characters, based on prejudice
and my org-mode use case (which breaks on brackets in the subject).
This allow to use e.g.
[[<thunderlink>][Email: <filteredSubject>]]as a nice org-mode link template that tends to actually work.
Probably the filtered characters should be configurable as well, but this is not done yet.